From 097ce6aff4d0567035d73af8025559fc34c34a61 Mon Sep 17 00:00:00 2001 From: ryo-ma Date: Sat, 19 Sep 2020 23:13:12 +0900 Subject: [PATCH] Fix get option params method when value is Nan --- src/utils.ts | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/utils.ts b/src/utils.ts index 17fa348..7a27dc1 100644 --- a/src/utils.ts +++ b/src/utils.ts @@ -7,24 +7,26 @@ export class CustomURLSearchParams extends URLSearchParams { super(init); } getStringValue(key: string, defaultValue: string): string { - let value: string = defaultValue; if (super.has(key)) { const param = super.get(key); if (param !== null) { return param.toString(); } } - return value.toString(); + return defaultValue.toString(); } getNumberValue(key: string, defaultValue: number): number { - let value: number = defaultValue; if (super.has(key)) { const param = super.get(key); if (param !== null) { - return parseInt(param); + const parsedValue = parseInt(param); + if (isNaN(parsedValue)) { + return defaultValue; + } + return parsedValue; } } - return value; + return defaultValue; } } @@ -68,5 +70,4 @@ export enum RANK { UNKNOWN = "?", } - export const RANK_ORDER = Object.values(RANK);