fix: handle GitHub GraphQL star failures (#454)

* fix(request): fail on GraphQL errors instead of returning partial data

* fix(user-info,schemas): use stargazerCount instead of stargazers connection

* test(request): reject partial GraphQL responses

* fix(config): use PAT names for GitHub tokens

* fix: validate star counts and GraphQL failures

* revert: preserve GitHub token environment names
This commit is contained in:
luo jiyin 2026-07-25 07:59:47 +08:00 • committed by GitHub
parent 119ea4cd3d
commit 0dbd570fb3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
12 changed files with 225 additions and 322 deletions

View file

@ -51,9 +51,7 @@ export const queryUserRepository = `
name name
} }
} }
stargazers { stargazerCount
totalCount
}
createdAt createdAt
} }
} }
@ -93,9 +91,7 @@ export const queryUserAll = `
name name
} }
} }
stargazers { stargazerCount
totalCount
}
createdAt createdAt
} }
} }

View file

@ -94,7 +94,7 @@ export class GithubApiService extends GithubRepository {
); );
}); });
} catch (error) { } catch (error) {
if (error.cause instanceof ServiceError) { if (error instanceof Error && error.cause instanceof ServiceError) {
Logger.error(error.cause.message); Logger.error(error.cause.message);
return error.cause; return error.cause;
} }

View file

@ -13,9 +13,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 23
"totalCount": 23
}
}, },
{ {
"languages": { "languages": {
@ -25,9 +23,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 11
"totalCount": 11
}
}, },
{ {
"languages": { "languages": {
@ -37,9 +33,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 9
"totalCount": 9
}
}, },
{ {
"languages": { "languages": {
@ -49,9 +43,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 6
"totalCount": 6
}
}, },
{ {
"languages": { "languages": {
@ -61,9 +53,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 6
"totalCount": 6
}
}, },
{ {
"languages": { "languages": {
@ -73,9 +63,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 5
"totalCount": 5
}
}, },
{ {
"languages": { "languages": {
@ -85,9 +73,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 5
"totalCount": 5
}
}, },
{ {
"languages": { "languages": {
@ -97,9 +83,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 5
"totalCount": 5
}
}, },
{ {
"languages": { "languages": {
@ -109,9 +93,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 4
"totalCount": 4
}
}, },
{ {
"languages": { "languages": {
@ -121,9 +103,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 3
"totalCount": 3
}
}, },
{ {
"languages": { "languages": {
@ -133,9 +113,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 2
"totalCount": 2
}
}, },
{ {
"languages": { "languages": {
@ -145,9 +123,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 2
"totalCount": 2
}
}, },
{ {
"languages": { "languages": {
@ -157,17 +133,13 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 2
"totalCount": 2
}
}, },
{ {
"languages": { "languages": {
"nodes": [] "nodes": []
}, },
"stargazers": { "stargazerCount": 1
"totalCount": 1
}
}, },
{ {
"languages": { "languages": {
@ -177,9 +149,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 1
"totalCount": 1
}
}, },
{ {
"languages": { "languages": {
@ -195,9 +165,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 1
"totalCount": 1
}
}, },
{ {
"languages": { "languages": {
@ -213,9 +181,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 1
"totalCount": 1
}
}, },
{ {
"languages": { "languages": {
@ -225,9 +191,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 1
"totalCount": 1
}
}, },
{ {
"languages": { "languages": {
@ -243,9 +207,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 1
"totalCount": 1
}
}, },
{ {
"languages": { "languages": {
@ -261,9 +223,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 1
"totalCount": 1
}
}, },
{ {
"languages": { "languages": {
@ -279,9 +239,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 1
"totalCount": 1
}
}, },
{ {
"languages": { "languages": {
@ -294,9 +252,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 1
"totalCount": 1
}
}, },
{ {
"languages": { "languages": {
@ -312,9 +268,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 1
"totalCount": 1
}
}, },
{ {
"languages": { "languages": {
@ -327,9 +281,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 1
"totalCount": 1
}
}, },
{ {
"languages": { "languages": {
@ -345,9 +297,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 1
"totalCount": 1
}
}, },
{ {
"languages": { "languages": {
@ -363,9 +313,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 1
"totalCount": 1
}
}, },
{ {
"languages": { "languages": {
@ -375,9 +323,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 1
"totalCount": 1
}
}, },
{ {
"languages": { "languages": {
@ -393,9 +339,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -411,9 +355,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -429,25 +371,19 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
"nodes": [] "nodes": []
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
"nodes": [] "nodes": []
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -463,9 +399,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -475,9 +409,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -487,9 +419,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -505,9 +435,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -523,17 +451,13 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
"nodes": [] "nodes": []
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -546,9 +470,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -564,9 +486,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -582,9 +502,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -597,9 +515,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -615,9 +531,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -633,9 +547,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -651,9 +563,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -669,9 +579,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -687,9 +595,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -699,9 +605,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -714,9 +618,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -732,9 +634,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -744,9 +644,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -759,9 +657,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -771,9 +667,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -783,9 +677,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -801,9 +693,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -819,9 +709,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -831,9 +719,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -846,9 +732,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -864,9 +748,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -882,9 +764,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -894,17 +774,13 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
"nodes": [] "nodes": []
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -917,9 +793,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -935,9 +809,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -953,9 +825,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -971,9 +841,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -989,9 +857,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1001,9 +867,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1019,9 +883,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1031,9 +893,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1049,9 +909,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1064,9 +922,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1079,9 +935,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1097,9 +951,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1115,9 +967,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1133,9 +983,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1145,9 +993,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1163,9 +1009,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1175,9 +1019,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1193,9 +1035,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1211,9 +1051,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1223,9 +1061,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1238,9 +1074,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1250,9 +1084,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1268,9 +1100,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1283,9 +1113,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1301,9 +1129,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1319,9 +1145,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1337,9 +1161,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1355,9 +1177,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1373,9 +1193,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1391,9 +1209,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1409,9 +1225,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1427,9 +1241,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1445,9 +1257,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1463,9 +1273,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1481,9 +1289,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1493,9 +1299,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1511,9 +1315,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
}, },
{ {
"languages": { "languages": {
@ -1529,9 +1331,7 @@
} }
] ]
}, },
"stargazers": { "stargazerCount": 0
"totalCount": 0
}
} }
] ]
} }

View file

@ -82,7 +82,7 @@ Deno.test("Should get data in first try", async () => {
Deno.test("Should throw NOT FOUND", async () => { Deno.test("Should throw NOT FOUND", async () => {
const provider = new GithubApiService(); const provider = new GithubApiService();
let error = null; let error: unknown = null;
try { try {
error = await provider.requestUserInfo("test"); error = await provider.requestUserInfo("test");
@ -90,12 +90,12 @@ Deno.test("Should throw NOT FOUND", async () => {
error = e; error = e;
} }
assertEquals(error.code, 404); assertEquals((error as ServiceError).code, 404);
assertEquals(error instanceof ServiceError, true); assertEquals(error instanceof ServiceError, true);
}); });
Deno.test("Should throw NOT FOUND even if request the user only", async () => { Deno.test("Should throw NOT FOUND even if request the user only", async () => {
const provider = new GithubApiService(); const provider = new GithubApiService();
let error = null; let error: unknown = null;
try { try {
error = await provider.requestUserRepository("test"); error = await provider.requestUserRepository("test");
@ -103,7 +103,7 @@ Deno.test("Should throw NOT FOUND even if request the user only", async () => {
error = e; error = e;
} }
assertEquals(error.code, 404); assertEquals((error as ServiceError).code, 404);
assertEquals(error instanceof ServiceError, true); assertEquals(error instanceof ServiceError, true);
}); });
@ -112,7 +112,7 @@ Deno.test("Should throw NOT FOUND even if request the user only", async () => {
// https://docs.deno.com/runtime/manual/basics/testing/assertions#throws // https://docs.deno.com/runtime/manual/basics/testing/assertions#throws
Deno.test("Should throw RATE LIMIT", async () => { Deno.test("Should throw RATE LIMIT", async () => {
const provider = new GithubApiService(); const provider = new GithubApiService();
let error = null; let error: unknown = null;
try { try {
error = await provider.requestUserRepository("test"); error = await provider.requestUserRepository("test");
@ -120,13 +120,13 @@ Deno.test("Should throw RATE LIMIT", async () => {
error = e; error = e;
} }
assertEquals(error.code, 419); assertEquals((error as ServiceError).code, 419);
assertEquals(error instanceof ServiceError, true); assertEquals(error instanceof ServiceError, true);
}); });
Deno.test("Should throw RATE LIMIT Exceed", async () => { Deno.test("Should throw RATE LIMIT Exceed", async () => {
const provider = new GithubApiService(); const provider = new GithubApiService();
let error = null; let error: unknown = null;
try { try {
error = await provider.requestUserRepository("test"); error = await provider.requestUserRepository("test");
@ -134,6 +134,6 @@ Deno.test("Should throw RATE LIMIT Exceed", async () => {
error = e; error = e;
} }
assertEquals(error.code, 419); assertEquals((error as ServiceError).code, 419);
assertEquals(error instanceof ServiceError, true); assertEquals(error instanceof ServiceError, true);
}); });

View file

@ -0,0 +1,27 @@
import { assertEquals, assertRejects, soxa, stub } from "../../../deps.ts";
import { EServiceKindError, ServiceError } from "../../Types/index.ts";
import { requestGithubData } from "../request.ts";
Deno.test("requestGithubData rejects partial GraphQL responses", async () => {
const post = stub(soxa, "post", () => {
return Promise.resolve({
data: {
data: { user: { login: "test" } },
errors: [{ message: "Field access failed", type: "FORBIDDEN" }],
},
});
});
try {
const error = await assertRejects(
() => requestGithubData("query { viewer { login } }", {}),
ServiceError,
"Field access failed",
) as ServiceError;
assertEquals(error.cause, EServiceKindError.UPSTREAM);
assertEquals(error.code, 502);
} finally {
post.restore();
}
});

View file

@ -2,8 +2,6 @@ import { soxa } from "../../deps.ts";
import { import {
EServiceKindError, EServiceKindError,
GithubError, GithubError,
GithubErrorResponse,
GithubExceedError,
QueryDefaultResponse, QueryDefaultResponse,
ServiceError, ServiceError,
} from "../Types/index.ts"; } from "../Types/index.ts";
@ -21,6 +19,20 @@ export async function requestGithubData<T = unknown>(
}) as QueryDefaultResponse<{ user: T }>; }) as QueryDefaultResponse<{ user: T }>;
const responseData = response.data; const responseData = response.data;
if (responseData?.errors?.length) {
console.error(
"GitHub GraphQL errors:",
JSON.stringify(responseData.errors, null, 2),
);
throw new ServiceError(
responseData.errors
.map((error) => error.message)
.join("; "),
getGraphQLErrorKind(responseData.errors),
);
}
if (responseData?.data?.user) { if (responseData?.data?.user) {
return responseData.data.user; return responseData.data.user;
} }
@ -28,6 +40,22 @@ export async function requestGithubData<T = unknown>(
throw handleError(responseData); throw handleError(responseData);
} }
function getGraphQLErrorKind(errors: GithubError[]): EServiceKindError {
const errorTypes = errors.map((error) => error.type);
if (
errorTypes.some((type) => type?.includes(EServiceKindError.RATE_LIMIT))
) {
return EServiceKindError.RATE_LIMIT;
}
if (errorTypes.every((type) => type === EServiceKindError.NOT_FOUND)) {
return EServiceKindError.NOT_FOUND;
}
return EServiceKindError.UPSTREAM;
}
function handleError( function handleError(
responseData: { responseData: {
data?: unknown; data?: unknown;

View file

@ -1,4 +1,5 @@
export const enum EServiceKindError { export const enum EServiceKindError {
RATE_LIMIT = "RATE_LIMITED", RATE_LIMIT = "RATE_LIMITED",
NOT_FOUND = "NOT_FOUND", NOT_FOUND = "NOT_FOUND",
UPSTREAM = "UPSTREAM",
} }

View file

@ -14,6 +14,8 @@ export class ServiceError extends Error {
return 419; return 419;
case EServiceKindError.NOT_FOUND: case EServiceKindError.NOT_FOUND:
return 404; return 404;
case EServiceKindError.UPSTREAM:
return 502;
default: default:
return 400; return 400;
} }

View file

@ -0,0 +1,41 @@
import { assertEquals } from "../../deps.ts";
import { UserInfo } from "../user_info.ts";
Deno.test("UserInfo calculates total stargazers", () => {
const userInfo = new UserInfo(
{
createdAt: "2025-01-01T00:00:00Z",
contributionsCollection: {
restrictedContributionsCount: 0,
totalCommitContributions: 0,
totalPullRequestReviewContributions: 0,
},
organizations: { totalCount: 0 },
followers: { totalCount: 0 },
},
{
openIssues: { totalCount: 0 },
closedIssues: { totalCount: 0 },
},
{ pullRequests: { totalCount: 0 } },
{
repositories: {
totalCount: 2,
nodes: [
{
languages: { nodes: [] },
stargazerCount: 3,
createdAt: "2025-01-01T00:00:00Z",
},
{
languages: { nodes: [] },
stargazerCount: 5,
createdAt: "2025-01-02T00:00:00Z",
},
],
},
},
);
assertEquals(userInfo.totalStargazers, 8);
});

View file

@ -128,3 +128,8 @@ export class Error404 extends BaseError {
readonly status = 404; readonly status = 404;
readonly message = "Not Found"; readonly message = "Not Found";
} }
export class Error502 extends BaseError {
readonly status = 502;
readonly message = "Bad Gateway";
}

View file

@ -1,12 +1,12 @@
import { EServiceKindError, ServiceError } from "../Types/index.ts"; import { EServiceKindError, ServiceError } from "../Types/index.ts";
import { Error400, Error404, Error419 } from "../error_page.ts"; import { Error400, Error404, Error419, Error502 } from "../error_page.ts";
interface ErrorPageProps { interface ErrorPageProps {
error: ServiceError; error: ServiceError;
} }
export function ErrorPage({ error }: ErrorPageProps) { export function ErrorPage({ error }: ErrorPageProps) {
let cause: Error400 | Error404 | Error419 = new Error400(); let cause: Error400 | Error404 | Error419 | Error502 = new Error400();
if (error.cause === EServiceKindError.RATE_LIMIT) { if (error.cause === EServiceKindError.RATE_LIMIT) {
cause = new Error419(); cause = new Error419();
@ -18,5 +18,9 @@ export function ErrorPage({ error }: ErrorPageProps) {
); );
} }
if (error.cause === EServiceKindError.UPSTREAM) {
cause = new Error502("GitHub returned an unexpected response.");
}
return cause; return cause;
} }

View file

@ -1,8 +1,7 @@
type Language = { name: string }; type Language = { name: string };
type Stargazers = { totalCount: number };
type Repository = { type Repository = {
languages: { nodes: Language[] }; languages: { nodes: Language[] };
stargazers: Stargazers; stargazerCount: number;
createdAt: string; createdAt: string;
}; };
export type GitHubUserRepository = { export type GitHubUserRepository = {
@ -78,7 +77,7 @@ export class UserInfo {
userActivity.contributionsCollection.totalCommitContributions; userActivity.contributionsCollection.totalCommitContributions;
const totalStargazers = userRepository.repositories.nodes.reduce( const totalStargazers = userRepository.repositories.nodes.reduce(
(prev: number, node: Repository) => { (prev: number, node: Repository) => {
return prev + node.stargazers.totalCount; return prev + node.stargazerCount;
}, },
0, 0,
); );