From 607cc64be1508c4b31552d6cb70d770f0e36cdf1 Mon Sep 17 00:00:00 2001 From: Ray Arayilakath Date: Mon, 10 May 2021 09:20:31 -0500 Subject: [PATCH] feat(organization): multiple additions to trophy Kewl new trophy! I have a few ideas: The title "Multiple Jobs" seems a bit... normal if you get what I mean. Can we try "Jack of all Trades", which sounds interesting. One problem is it might be too big, so we could go with "Factotum" which basically means the same thing (someone who is skilled in/does multiple fields/jobs) and sounds really awesome as well. In addition I raised the requirement to three organizations because two organizations is a little too easy. I also added the "Orgs" and "Teams" aliases to the filterTitles so that the size of the url can be smaller. Let me know what you think :) --- src/trophy.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/trophy.ts b/src/trophy.ts index 6e7a4c1..6d218af 100644 --- a/src/trophy.ts +++ b/src/trophy.ts @@ -187,13 +187,14 @@ export class MultipleOrganizationsTrophy extends Trophy{ const rankConditions = [ new RankCondition( RANK.SECRET, - "Multiple Jobs", - 2, + // or if this doesn't render well: "Factorum" + "Jack of all Trades", + 3, ), ]; super(score, rankConditions); this.title = "Organizations"; - this.filterTitles = ["Organizations"]; + this.filterTitles = ["Organizations", "Orgs", "Teams"]; this.hidden = true; } }